Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fix language switcher #524

Merged
merged 7 commits into from
Jul 20, 2023
Merged

[Bug]: Fix language switcher #524

merged 7 commits into from
Jul 20, 2023

Conversation

kingjia90
Copy link
Contributor

@kingjia90 kingjia90 commented Jul 18, 2023

Resolves #517

Previously when trying to switch language on any static routes, it would just redirect to home page of the selected language.
An attempt to fix it was provided on #435 but it caused to stop working on normal documents.
This PR provides the fix and also returns the translated slugs (which 435 did only prepend the /de and /en)

@kingjia90 kingjia90 linked an issue Jul 18, 2023 that may be closed by this pull request
@kingjia90 kingjia90 added this to the 10.3.3 milestone Jul 18, 2023
@kingjia90 kingjia90 marked this pull request as draft July 19, 2023 07:13
@kingjia90 kingjia90 marked this pull request as ready for review July 19, 2023 08:20
@robertSt7 robertSt7 added the Bug label Jul 19, 2023
@dvesh3 dvesh3 merged commit 9573b1e into 10.3 Jul 20, 2023
1 check passed
@dvesh3 dvesh3 deleted the fix-language-switcher branch July 20, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Language Switcher on main pages doesn't work ?_locale=xx
3 participants