Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests]: Add strategy matrix to cover all the versions and mysql engine #542

Merged
merged 14 commits into from Sep 13, 2023
Merged

[Tests]: Add strategy matrix to cover all the versions and mysql engine #542

merged 14 commits into from Sep 13, 2023

Conversation

kingjia90
Copy link
Contributor

@kingjia90 kingjia90 commented Sep 11, 2023 •
edited

Resolves #537

@kingjia90 kingjia90 changed the base branch from 11.x to 11.0 September 11, 2023 18:10
@kingjia90 kingjia90 added the Task label Sep 12, 2023
@kingjia90 kingjia90 changed the title [Draft][Test]: Add test for upgrading [Tests]: Add strategy matrix to cover all the versions and mysql engine Sep 12, 2023
@kingjia90 kingjia90 marked this pull request as ready for review September 12, 2023 13:11
dvesh3
dvesh3 reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@dvesh3 dvesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see review marks below.

Also, It seems like we are still running tests for installation and upgrade tests are missing.

.github/workflows/pimcore-demo.yml Outdated Show resolved Hide resolved
.github/workflows/pimcore-demo.yml Outdated Show resolved Hide resolved
@dvesh3 dvesh3 merged commit 4b480d0 into 11.0 Sep 13, 2023
4 checks passed
@dvesh3 dvesh3 deleted the improve-tests branch September 13, 2023 15:02
@dvesh3 dvesh3 mentioned this pull request Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvesh3 dvesh3 dvesh3 approved these changes

Assignees

@dvesh3 dvesh3

@kingjia90 kingjia90

Labels
Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for running upgrade
2 participants
@kingjia90 @dvesh3