disallow special characters for asset filenames, see also #2971

pimcore · Jul 18, 2018 · 270ad50 · 270ad50
1 parent fa07461
commit 270ad50
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/...ment_Documentation/23_Installation_and_Upgrade/09_Upgrade_Notes/01_Within_V5.md b/...ment_Documentation/23_Installation_and_Upgrade/09_Upgrade_Notes/01_Within_V5.md
@@ -3,6 +3,9 @@
 
 ## Version 5.3.0
 
+#### Build 285 (2018-07-18)
+Asset filenames: introduced new policy, the following disallowed characters were added: `#?*:\<>|"` 
+
 #### Build 281 (2018-07-13)
 The admin UI translations are not split into 2 parts, 
 [Essentials](https://poeditor.com/join/project/VWmZyvFVMH) and [Extended](https://poeditor.com/join/project/XliCYYgILb). 

diff --git a/pimcore/models/Element/Service.php b/pimcore/models/Element/Service.php
@@ -888,6 +888,9 @@ public static function getValidKey($key, $type)
             // keys shouldn't start with a "." (=hidden file) *nix operating systems
             // keys shouldn't end with a "." - Windows issue: filesystem API trims automatically . at the end of a folder name (no warning ... et al)
             $key = trim($key, '. ');
+
+            // windows forbidden filenames + URL reserved characters (at least the once which are problematic)
+            $key = preg_replace('/[#\?\*\:\\\\<\>\|"]/', '-', $key);
         } else {
             $key = trim($key);
             $key = ltrim($key, '.');