Skip to content

Commit

Permalink
fixed the isFieldDirty to avoid uninitialised keys
Browse files Browse the repository at this point in the history
it will avoid getting the warning bellow:

Notice: Undefined index: o_parentId
#0 <project>/vendor/pimcore/pimcore/models/DataObject/Concrete/Dao.php(226): Pimcore\Model\DataObject\Colour->isFieldDirty('o_parentId')
#1 <project>/vendor/pimcore/pimcore/models/DataObject/Concrete.php(222): Pimcore\Model\DataObject\Concrete\Dao->update(true, Array)
#3 <project>/vendor/pimcore/pimcore/models/DataObject/AbstractObject.php(644): Interceptor\Main->update(true, Array)
#4 <project>/vendor/pimcore/pimcore/models/DataObject/Concrete.php(705): Pimcore\Model\DataObject\AbstractObject->save()
  • Loading branch information
paulovitorbal committed Nov 16, 2018
1 parent d57128d commit 8244ad3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion models/DataObject/Traits/DirtyIndicatorTrait.php
Expand Up @@ -39,7 +39,7 @@ public function hasDirtyFields()
*/
public function isFieldDirty($key)
{
if (is_array($this->o_dirtyFields) && $this->o_dirtyFields[$key]) {
if (is_array($this->o_dirtyFields) && array_key_exists($key, $this->o_dirtyFields)) {
return true;
}

Expand Down

0 comments on commit 8244ad3

Please sign in to comment.