[Advanced relations] Do not check for type equality of meta fields (#…

…12595) * compare meta field values without type checking * upgrade notes
pimcore · Sep 2, 2022 · d0cc2c1 · d0cc2c1
1 parent bd79cba
commit d0cc2c1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/...evelopment_Documentation/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md b/...evelopment_Documentation/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md
@@ -10,7 +10,8 @@
   - Removed Token condition
   - Removed methods `getSession()` & `setSession()` from `PricingManager\EnvironmentInterface`
 - [Data Objects] Remove "generate type declarations" in class definitions
-- [DataObjects] Removed method_exists bc layer, please use the corresponding interfaces instead. For details please see [#9571](https://github.com/pimcore/pimcore/issues/9571)
+- [Data Objects] Removed method_exists bc layer, please use the corresponding interfaces instead. For details please see [#9571](https://github.com/pimcore/pimcore/issues/9571)
+- [Data Objects] `isEqual()` for advanced relational field types does not check for type equality of meta fields anymore, see [#12595](https://github.com/pimcore/pimcore/pull/12595)
 - [Listings] Removed `JsonListing`, please see [#12877](https://github.com/pimcore/pimcore/pull/12877) for details.
 - [Traits] The traits PackageVersionTrait and StateHelperTrait in lib/Extension/Bundle/Traits have been marked as
    internal, please see [#12757](https://github.com/pimcore/pimcore/pull/12757) for details.

diff --git a/models/DataObject/Traits/ElementWithMetadataComparisonTrait.php b/models/DataObject/Traits/ElementWithMetadataComparisonTrait.php
@@ -62,7 +62,7 @@ public function isEqual($array1, $array2): bool
 
             $data1 = $container1->getData();
             $data2 = $container2->getData();
-            if (serialize($data1) != serialize($data2)) {
+            if ($data1 != $data2) {
                 return false;
             }
         }