-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TineMCE WYSIWYG Editor #2499
Comments
That sounds dangerous. A lot of my project depend on it as I either
So, this is at least a BC Break and needs to be well thought thru. |
Is there any reason CKEditor must be replaced ? |
@Yivan Yes, version 4 of CKEditor will not be supported forever We'll perform this change in 3 steps:
|
@brusch @dpfaffenbauer |
CKEditor 5 is not backward-compatible to version 4. |
I hope the "alternative" will be CKEditor 5 because it's not only a new version of CKEditor but a really great WYSIWYG editor which does not depend on the contenteditable attribute [1] like most popular WYSIWYG editors (CKEditor 4, TinyMCE, Redactor, …) which is one of the main reasons for all the pain with WYSIWYG editors. Yes, CKEditor 5 does not yet have as many features as the CKEditor 4 but enough for a lot of projects and since CKEditor 4 will remain the default in the first step it's okay to have some features at a later point and it would be an investment in the future of content editing. [1] https://ckeditor.com/blog/CKEditor-5-A-new-era-for-rich-text-editing/ |
@kirjavascript recommended me this one https://prosemirror.net/ - looks pretty lightweight and supports back to IE11 (eugh) |
I'd recommend https://quilljs.com/ to have another alternative. ;) |
CKEditor 5 looks promising tbh. If it has the same features as version 4, why not use that. (Providing the BC config @brusch mentioned ;)) |
I would like to push this topic, since there's a bug since 2016 (see #1124) that makes all WYSIWYG fields useless in my opinion, since you can not specify or limt tags and functiononalities users can create and manage. And you don't want to have the possibilities to offer adding headings for example, when placing the WYSIWYG content already inside a heading. I've already filled a bug at the CKEditor repository, however, it's unlikely that this will be solved soon or at all since a contributor mentioned that this is a general architecture problem of CKEditor. And since So I'm curious @pimcore: What are the current plans to move forward with WYSIWYG editable fields, with which editor or version and in which timeline? |
Hi, you can specify tags that users are allowed to create, and get around #1124 by inserting config directly into the editable. See my example, I have disallowed h1 tags on blog post content :) https://gist.github.com/cleggypdc/e07c8314067e48238e191ecaf57ff9b5 |
Thanks a lot for this tip @cleggypdc! I will try this out next week. |
It works @cleggypdc, thanks very much! However, two things to notice:
|
The "... or later" part is important here, isn't it? https://github.com/ckeditor/ckeditor5/blob/master/LICENSE.md
https://www.gnu.org/licenses/quick-guide-gplv3.html#new-compatible-licenses
So, couldn't Pimcore choose to license it under GPLv3 for the community edition? https://www.gnu.org/licenses/gpl-3.0.html#section14
|
Actually no, not for licensing reasons, but we don't want to maintain 2 editors, one for CE one for EE 😉 |
Why not license the same CK Editor with GPLv2 for EE and GPLv3 for CE? |
Pimcore EE is not GPL! |
Isn't CK Editor 4 used under GPLv2 today in EE or do you have a custom license? Edit: What I am asking is, what is the material difference between the GPLv2 for CK Editor that allows compatibility with EE today that prevents version 5 from doing the same? |
LGPL & MPL vs. GPL only... |
Which one of those do you consider compatible with the EE license? |
Did you reach out to CKSource?
|
@cadeyrn the problem is NOT the community edition licensed under the terms of the GPLv3 which would be compatible, the problem IS our enterprise edition, which is licensed under a proprietary license. |
If Commercial Use as defined there is your threshold requirement for license choice, GPLv2 which CKEditor uses also allows Commercial Use (as does GPLv3 by the way). What is the material difference in the forms of Commercial Use they allow that makes you say it is incompatible? |
@NiklasBr commercial use !== commercial license So, PCL is a proprietary license, that is incompatible with GPL. 😉 |
You wrote commercial use, which is why I asked. |
Many others, see e.g. Most of them are dead, abandoned, ... Any other suggestions? |
@brusch we recently used https://tiptap.dev on some of our projects and had a great developer experience. License is MIT. |
We, too, used tiptap.dev for a project and had a wonderful time integrating it, worked like a charm with the TYPO3 project |
@Cruiser13 @ChrisB9 but tiptap doesn't offer "inline" - editing (floating toolbar) as CKEditor and TinyMCE do, right? |
@brusch that's called floating menu for tiptap and is an official extension. You can find it here: https://tiptap.dev/api/extensions/floating-menu |
@Cruiser13 Thanks! |
@brusch How was/is this not included in the v11 upgrade guide? There no mention that explicit action needs to be taken if you want to continue to use a WYSIWYG in the PIM/CMS. Nor is there any mention that if you've added config specific to CKEditor, that needs to be migrated to support TinyMCE when upgrading. https://pimcore.com/docs/platform/Pimcore/Installation_and_Upgrade/Upgrade_Notes/ It would be helpful to have a section about the WYSIWYG for others using these upgrade guides. |
@tmannherz yes, the upgrade guide is missing at the moment. I have created an issue to add the related info to the docs. thanks for reporting 👍 |
No description provided.
The text was updated successfully, but these errors were encountered: