[Webservices] Do not deliver inherited values

[fashxp]

currently it delivers inherited values except of classification store.

[dpfaffenbauer]

wouldn't it be better to somehow configure that with a param or so? just disabling inheritance could cause issues now for some people

[fashxp]

can we find out how long it has been wrong?

[dpfaffenbauer]

I guess thats difficult to do. Guess the best way is to test it with a existing Pimcore 4 installation.

I just checked the RestController in Pimcore 4 and there is no disabling of inheritance there.

[fashxp]

in pimcore 4 inherited values were definitely not delivered

[weisswurstkanone]

mhm ... PimcoreContextListener ($context would be "webservice" in our case) ... explicitly enables it

protected function initializeContext($context)
{
    if ($context == PimcoreContextResolver::CONTEXT_ADMIN) {
        \Pimcore::setAdminMode();
        Document::setHideUnpublished(false);
        DataObject\AbstractObject::setHideUnpublished(false);
        DataObject\AbstractObject::setGetInheritedValues(false);
        DataObject\Localizedfield::setGetFallbackValues(false);
    } else {
        \Pimcore::unsetAdminMode();
        Document::setHideUnpublished(true);
        DataObject\AbstractObject::setHideUnpublished(true);
        **DataObject\AbstractObject::setGetInheritedValues(true);**
        DataObject\Localizedfield::setGetFallbackValues(true);
    }
}

[weisswurstkanone]

IMO, behavior should be the same as for CONTEXT_ADMIN

[markus-moser]

related to #175

[dpfaffenbauer]

what speaks against a query parameter to enable/disable inheritance?

[fashxp]

I think it is the only option, since the behavior is since pimcore 5 to include inherited values.
that's the reason why I reopened the issue, we need to discuss that internally.

[fashxp]

Proposed Solution:

• Default behavior like in Pimcore 4 (no inheritance by default)
• Add param to change default behavior and enable inheritance
• Add upgrade notice and note in docs (https://pimcore.com/docs/master/Development_Documentation/Web_Services/index.html)

[dpfaffenbauer]

• Add Tests to test both behaviours ;)

[fashxp]

• Add Tests to test both behaviours ;)

pullrequests are as always welcome ;-)

[dpfaffenbauer]

and this now also works for classification stores? Which was the actual source of this problem.

PR: Well, tests should be included in the actual implementation ;)

[weisswurstkanone]

see #3269