[Element] Show notice message before closing a changed element

[smoench]

Bug Report / Feature Request

Expected behavior

Given an user is logged-in in the admin panel
When they are starts editing an object
And changing a value
When they accidentally closing the tab
Then an dialog appears which describes the repercussions
And the user can choose between "Closing" and "Abort"

Actual behavior

Given an user is logged-in in the admin panel
When they are starts editing an object
And changing a value
When they accidentally closing the tab
Then changes are lost

[fashxp]

should be already there

seems not to work anymore though, can you confirm?

[smoench]

I did not know about those options and I would not have excepted those options are enabled by default. Might be fair enough for admin users but opt-out those options on every new user is created is not very (user/admin) friendly. Having a "Don't show this message again" in those dialogs or having those options in group settings would be another solution.

When I opt-out "Disable unsaved content warning" and "Show close warning" everything works as expected. Thanks :-)

[brusch]

Show close warning is used for the Pimcore admin ui in general, not for individually opened entities, see

pimcore/bundles/AdminBundle/Resources/public/js/pimcore/startup.js

Line 169 in 6b76fba

if (pimcore.settings.showCloseConfirmation && tabPanel.items.getCount() > 0 && user["closeWarning"]) {

[smoench]

Yes, Show close warning is used for the Pimcore admin ui in general. The option Disable unsaved content warning is for a notice message before closing a changed element.

IMHO Disable unsaved content warning should be opt-out by default. This would be a huge improvement for the user experience.

[brusch]

@smoench agree!