Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not save assets in tree list calls #7520

Closed
markus-moser opened this issue Nov 12, 2020 · 0 comments · Fixed by #8763
Closed

Do not save assets in tree list calls #7520

markus-moser opened this issue Nov 12, 2020 · 0 comments · Fixed by #8763
Assignees

Comments

@markus-moser
Copy link
Contributor

markus-moser commented Nov 12, 2020

If image dimensions cannot be calculated the core will save the asset again and again in all tree list calls:

https://github.com/pimcore/pimcore/blob/master/bundles/AdminBundle/Controller/Admin/Asset/AssetController.php#L717

// this is for backward-compatibility, to calculate the dimensions if they are not there
if (!$asset->getCustomSetting('imageDimensionsCalculated')) {
        $asset->save();
}

This might happen for example if the asset is somehow corrupt or not in the file system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants