Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type column of object_relations_* tables to enum #10760

Merged
merged 4 commits into from Nov 18, 2021
Merged

Change type column of object_relations_* tables to enum #10760

merged 4 commits into from Nov 18, 2021

Conversation

BabovicT
Copy link
Contributor

@BabovicT BabovicT commented Nov 3, 2021

Resolves #10662

matthiashamacher
matthiashamacher approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@matthiashamacher matthiashamacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brusch brusch added this to the 10.3.0 milestone Nov 4, 2021
@brusch brusch self-assigned this Nov 17, 2021
brusch
brusch requested changes Nov 17, 2021
View reviewed changes
Copy link
Member

@brusch brusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my inline comment 😊
Would be nice if you could update the PR accordingly. Thanks in advance!

models/DataObject/ClassDefinition/Dao.php Outdated Show resolved Hide resolved
@brusch brusch merged commit a49e830 into pimcore:10.x Nov 18, 2021
@dvesh3 dvesh3 mentioned this pull request Feb 7, 2022
Closed
dvesh3 added a commit that referenced this pull request Feb 7, 2022
@dvesh3
[DataObjects] Change type column of object_relations_* tables to enum…
d1a4fe5 
… - follow up to #10760
@dvesh3 dvesh3 mentioned this pull request Feb 7, 2022
Merged
dvesh3 added a commit that referenced this pull request Feb 7, 2022
@dvesh3
[DataObjects] Change type column of object_relations_* tables to enum…
b8ea038 
… - follow up to #10760
brusch pushed a commit that referenced this pull request Feb 7, 2022
@dvesh3 @blankse
[DataObjects] Migrations - fix error: All parts of a PRIMARY KEY must…
ecb6a46 
… be NOT NULL (#11383)

* [DataObjects] Change type column of object_relations_* tables to enum - follow up to #10760

* [DataObjects] Change type column of object_relations_* tables to enum - follow up to #10760

* Update bundles/CoreBundle/Migrations/Version20211103055110.php

Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de>

* Update bundles/CoreBundle/Migrations/Version20211103055110.php

Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de>

Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brusch brusch brusch requested changes

@matthiashamacher matthiashamacher matthiashamacher approved these changes

Assignees

@brusch brusch

Labels
Improvement
Projects
None yet
Milestone
10.3.0
Development

Successfully merging this pull request may close these issues.

[Improvement]: Change type column of object_relations_* tables to enum
4 participants
@BabovicT @brusch @matthiashamacher @weisswurstkanone