[Task] Apply native parameter and return type hints according to php docs #13474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Checklist
|
mcop1
changed the title
fashxp
requested changes
Oct 28, 2022
bundles/CoreBundle/src/Command/Document/MigrateElementsCommand.php
Outdated
Show resolved
Hide resolved
fashxp
requested changes
Oct 31, 2022
...les/EcommerceFrameworkBundle/src/CoreExtensions/ClassDefinition/IndexFieldSelectionCombo.php
Outdated
Show resolved
Hide resolved
bundles/EcommerceFrameworkBundle/src/EventListener/IndexUpdateListener.php
Outdated
Show resolved
Hide resolved
bundles/EcommerceFrameworkBundle/src/EventListener/SessionBagListener.php
Outdated
Show resolved
Hide resolved
bundles/EcommerceFrameworkBundle/src/IndexService/ProductList/DefaultFindologic.php
Outdated
Show resolved
Hide resolved
bundles/EcommerceFrameworkBundle/src/IndexService/ProductList/DefaultFindologic.php
Outdated
Show resolved
Hide resolved
fashxp
requested changes
Oct 31, 2022
models/DataObject/ClassDefinition/Data/FieldDefinitionEnrichmentInterface.php
Outdated
Show resolved
Hide resolved
fashxp
requested changes
Nov 2, 2022
models/DataObject/ClassDefinition/Data/LayoutDefinitionEnrichmentInterface.php
Outdated
Show resolved
Hide resolved
models/DataObject/ClassDefinition/Data/ManyToManyObjectRelation.php
Outdated
Show resolved
Hide resolved
models/DataObject/ClassDefinition/Data/ManyToManyObjectRelation.php
Outdated
Show resolved
Hide resolved
fashxp
requested changes
Nov 7, 2022
… docs Fix for failing tests
fashxp
approved these changes
Nov 21, 2022
… docs Added upgrade notes
This was referenced Nov 22, 2022
kingjia90
pushed a commit
to pimcore/customer-data-framework
that referenced
this pull request
Nov 28, 2022
* [Task]: Apply native parameter and return type hints - related to pimcore/pimcore#13474 * [Task]: Apply native parameter and return type hints More return types and fixes added * [Task]: Apply native parameter and return type hints * [Task]: Apply native parameter and return type hints Co-authored-by: Marco Perberschlager <marco.perberschlager@pimcore.com>
dvesh3
added a commit
to pimcore/demo
that referenced
this pull request
Nov 29, 2022
* [Task]: Apply native parameter and return type hints - related to pimcore/pimcore#13474 * [Task]: Apply native parameter and return type hints More return types and fixes added * [Task]: Apply native parameter and return type hints * Remove Ecommerce override (#376) Co-authored-by: Marco Perberschlager <marco.perberschlager@pimcore.com>
Merged
This was referenced Dec 20, 2022
dvesh3
added a commit
that referenced
this pull request
Feb 6, 2023
mattamon
added a commit
that referenced
this pull request
Feb 8, 2023
* Fix Document::hasChildren param default value - follow up to #13474 * Apply suggestions from code review Co-authored-by: Matthias S. <38959016+mattamon@users.noreply.github.com> * Review changes * Expand params for better readability Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de> * Expand even more params for readability --------- Co-authored-by: Matthias S. <38959016+mattamon@users.noreply.github.com> Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de> Co-authored-by: mattamon <matthias.schuhmayer@pimcore.com>
This was referenced Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12240
Draft, tests not working yet.