Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix property_exists(): Passing null to parameter #2 ($property) of type string is deprecated #13854

Merged
merged 2 commits into from Dec 21, 2022

Conversation

jdreesen
Copy link
Contributor

Fixes:

Deprecated: property_exists(): Passing null to parameter #2 ($property) of type string is deprecated in /var/www/pimcore/vendor/pimcore/pimcore/models/DataObject/Traits/ObjectVarTrait.php on line 53

@github-actions
Copy link

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@dvesh3 dvesh3 added the Bug label Dec 20, 2022
@dvesh3 dvesh3 added this to the 10.5.13 milestone Dec 20, 2022
@blankse
Copy link
Contributor

blankse commented Dec 20, 2022

Should we also change the php doc to @param string|null $var if $var can be null?

@mcop1 mcop1 self-assigned this Dec 21, 2022
@mcop1
Copy link
Contributor

mcop1 commented Dec 21, 2022

As always, thank you guys 👍

@mcop1 mcop1 merged commit 60ab460 into pimcore:10.5 Dec 21, 2022
@jdreesen jdreesen deleted the patch-2 branch December 21, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants