Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Add pimcore_editmode_admin_language twig function #14074

Merged
merged 4 commits into from
Jan 25, 2023

Conversation

kingjia90
Copy link
Contributor

@kingjia90 kingjia90 commented Jan 16, 2023

Resolves #13161

Note:
See also twig translation

@kingjia90 kingjia90 added this to the 11.0.0 milestone Jan 16, 2023
@github-actions
Copy link

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

lib/Twig/Extension/AdminExtension.php Outdated Show resolved Hide resolved
lib/Twig/Extension/AdminExtension.php Outdated Show resolved Hide resolved
kingjia90 and others added 4 commits January 22, 2023 02:12
…entation about usage in admin domain translations
Co-authored-by: Sebastian Blank <blank@data-factory.net>
Co-authored-by: Sebastian Blank <blank@data-factory.net>
@dvesh3 dvesh3 self-assigned this Jan 23, 2023
@kingjia90 kingjia90 force-pushed the twig_add_pimcore_editmode_admin_language branch from 1ed96d7 to c8171ca Compare January 24, 2023 14:17
@kingjia90 kingjia90 changed the base branch from 11.x to 10.6 January 24, 2023 14:17
@kingjia90 kingjia90 modified the milestones: 11.0.0, 10.6.0 Jan 24, 2023
@dvesh3 dvesh3 merged commit fd6cdce into 10.6 Jan 25, 2023
@dvesh3 dvesh3 deleted the twig_add_pimcore_editmode_admin_language branch January 25, 2023 13:35
mcop1 pushed a commit that referenced this pull request Feb 13, 2023
* Task: add pimcore_editmode_admin_language twig function and add documentation about usage in admin domain translations

* Task: fix code

* Task: switch to constructor property promotion

Co-authored-by: Sebastian Blank <blank@data-factory.net>

* Task: use native return type

Co-authored-by: Sebastian Blank <blank@data-factory.net>

Co-authored-by: Sebastian Blank <blank@data-factory.net>
mcop1 pushed a commit that referenced this pull request Feb 13, 2023
* Task: add pimcore_editmode_admin_language twig function and add documentation about usage in admin domain translations

* Task: fix code

* Task: switch to constructor property promotion

Co-authored-by: Sebastian Blank <blank@data-factory.net>

* Task: use native return type

Co-authored-by: Sebastian Blank <blank@data-factory.net>

Co-authored-by: Sebastian Blank <blank@data-factory.net>
dvesh3 pushed a commit that referenced this pull request May 9, 2023
* Task: add pimcore_editmode_admin_language twig function and add documentation about usage in admin domain translations

* Task: fix code

* Task: switch to constructor property promotion

Co-authored-by: Sebastian Blank <blank@data-factory.net>

* Task: use native return type

Co-authored-by: Sebastian Blank <blank@data-factory.net>

Co-authored-by: Sebastian Blank <blank@data-factory.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Admin translation in Document to use current admin language
3 participants