-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12524 move googlemarketing to bundle #14276
Conversation
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
# Conflicts: # bundles/AdminBundle/public/js/pimcore/layout/toolbar.js # bundles/AdminBundle/templates/admin/index/index.html.twig # bundles/CoreBundle/src/DependencyInjection/PimcoreCoreExtension.php # bundles/GoogleMarketingBundle/public/js/report/analytics/elementexplorer.js # bundles/GoogleMarketingBundle/public/js/report/analytics/elementoverview.js # bundles/GoogleMarketingBundle/public/js/report/analytics/siteoverview.js # composer.json
bundles/GoogleMarketingBundle/.github/ci/files/config/system.yml
Outdated
Show resolved
Hide resolved
bundles/GoogleMarketingBundle/public/js/report/analytics/siteoverview.js
Outdated
Show resolved
Hide resolved
Remove unnecessary use statements Update docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, add:
- Migration to mark the bundle as installed and adding permissions.
- Upgrade notes for refactoring Marketing features & Removing Google CSE
bundles/EcommerceFrameworkBundle/src/Tracking/Tracker/Analytics/AbstractAnalyticsTracker.php
Show resolved
Hide resolved
# Conflicts: # bundles/GoogleMarketingBundle/docs/05_Analytics.md
….com/pimcore/pimcore into 12524-move-googlemarketing-to-bundle
wait, what happens to custom_report_adapter_analytics
reports after one uninstall the googlemarketing bundle?
Good catch! Added here 01cb843 |
Changes in this pull request
Resolves #12524
Resolves #14279
Additional info
Moving google marketing functionality into PimcoreGoogleMarketingBundle
Able to install and uninstall via Installer. Permissions are in the Bundle
Moved translations into the bundle