Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Type error in Predefined Asset Metadata #14347

Merged
merged 6 commits into from Feb 24, 2023
Merged

Fix Type error in Predefined Asset Metadata #14347

merged 6 commits into from Feb 24, 2023

Conversation

blankse
Copy link
Contributor

@blankse blankse commented Feb 15, 2023

Fix #14345

@github-actions
Copy link

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@blankse blankse mentioned this pull request Feb 15, 2023
Closed
@martineiber
Copy link
Contributor

@blankse could you please rebase this branch and check again. There semes to be an error after the rebase. Uncaught TypeError: Cannot read properties of undefined (reading 'replace') in pimcore/settings/metadatapredefined.js Line 68

Thank you.

@blankse
Copy link
Contributor Author

blankse commented Feb 24, 2023

@martineiber Okay I fixed it. The properties must be protected.

martineiber
martineiber approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@martineiber martineiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine!
Thank you for your contribution.

@martineiber martineiber merged commit 72c4e40 into pimcore:11.x Feb 24, 2023
@blankse blankse deleted the type_error_in_predefined_asset_metadata branch February 24, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martineiber martineiber martineiber approved these changes

Assignees

@martineiber martineiber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Type error in Predefined Asset Metadata
2 participants
@blankse @martineiber