Fix Xss in name field of custom reports #15007
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #
Additional info
WHAT
馃 Generated by Copilot at d6a57ca
This pull request fixes a XSS vulnerability in the custom report feature of the AdminBundle. It adds validation for the custom report name in the
CustomReportController
class and encodes/decodes the name in thepanel.js
file.馃 Generated by Copilot at d6a57ca
HOW
馃 Generated by Copilot at d6a57ca
isValidConfigName
inCustomReportController.php
to avoid code duplication and improve readability (link)panel.js
to prevent XSS vulnerability (link)