Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Hardlink.php #15386

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Update Hardlink.php #15386

merged 1 commit into from
Jun 27, 2023

Conversation

j-jonas
Copy link
Contributor

@j-jonas j-jonas commented Jun 16, 2023

set initialization values / add null as possible type

at the moment it is not possible to create a hardlink:

// Timestamp: Fri Jun 16 2023 11:14:17 GMT+0200 (Mitteleuropäische Sommerzeit) Status: 500 | URL: /admin/document/add Method: POST Message: Typed property Pimcore\Model\Document\Hardlink::$propertiesFromSource must not be accessed before initialization

@j-jonas
Update Hardlink.php
5fef52e 
set initialization values / add null as possible type
@github-actions
Copy link

Review Checklist

  • Target branch (10.6 for bug fixes for Pimcore 10, 11.0 for bug fixes for Pimcore 11 and 11.x for features and improvements for Pimcore 11)
  • Bug fix: check if files are affected that were moved to a bundle - create a PR there if applicable
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

No Coverage information No Coverage information
13.6% 13.6% Duplication

@brusch brusch added the Bug label Jun 19, 2023
@dvesh3 dvesh3 added this to the 11.0.3 milestone Jun 27, 2023
@dvesh3 dvesh3 merged commit a1fce9a into pimcore:11.0 Jun 27, 2023
16 checks passed
dvesh3 added a commit to pimcore/data-hub that referenced this pull request Jun 27, 2023
@dvesh3
[DocumentResolver] Hardlink - optimize resolveTarget - related to pim…
8b17029 
…core/pimcore#15386
@dvesh3 dvesh3 mentioned this pull request Jun 27, 2023
Merged
dvesh3 added a commit that referenced this pull request Jun 27, 2023
@dvesh3
Make phpdoc consistent with higher version - Related to #15386 & #15440
c717932
@dvesh3 dvesh3 mentioned this pull request Jun 27, 2023
Merged
robertSt7 pushed a commit to pimcore/data-hub that referenced this pull request Jul 20, 2023
@dvesh3
[DocumentResolver] Hardlink - optimize resolveTarget - related to pim…
8bfe60b 
…core/pimcore#15386 (#763)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvesh3 dvesh3 dvesh3 approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
11.0.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@j-jonas @dvesh3 @brusch