Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the type error in saving a document link #15486

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Fix the type error in saving a document link #15486

merged 1 commit into from
Jul 6, 2023

Conversation

aryaantony92
Copy link
Contributor

@aryaantony92 aryaantony92 commented Jul 6, 2023 •
edited

Create a document link and try to save it
Screenshot 2023-07-06 135752

Changes in this pull request

Resolves #

Additional info

WHAT

馃 Generated by Copilot at bfa3bd6

Fix internal link ID bug in Link class. Allow setInternal method to accept null values and handle them correctly.

馃 Generated by Copilot at bfa3bd6

setInternal changed
nullable integer now
autumn bug is fixed

HOW

馃 Generated by Copilot at bfa3bd6

  • Fix a bug where the internal link ID was not properly saved or loaded in the admin interface (link)

@github-actions
Copy link

github-actions bot commented Jul 6, 2023 •
edited by robertSt7

Review Checklist

  • Target branch (10.6 for bug fixes for Pimcore 10, 11.0 for bug fixes for Pimcore 11 and 11.x for features and improvements for Pimcore 11)
  • Bug fix: check if files are affected that were moved to a bundle - create a PR there if applicable
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@aryaantony92 aryaantony92 changed the title Fixes Fix the type error in saving a document link Jul 6, 2023
@aryaantony92 aryaantony92 modified the milestones: 10.6.4, 11.0.3 Jul 6, 2023
@robertSt7 robertSt7 self-assigned this Jul 6, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@robertSt7 robertSt7 merged commit 5e53ba1 into 11.0 Jul 6, 2023
17 checks passed
@robertSt7 robertSt7 deleted the fix_link_save branch July 6, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@robertSt7 robertSt7

Labels
Bug
Projects
None yet
Milestone
11.0.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aryaantony92 @robertSt7