Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CoreBundle] Fix down migrations by removing IF EXISTS, not a valid MySQL 8 statements #15792

Merged
merged 1 commit into from Aug 21, 2023
Merged

[CoreBundle] Fix down migrations by removing IF EXISTS, not a valid MySQL 8 statements #15792

merged 1 commit into from Aug 21, 2023

Conversation

dvesh3
Copy link
Contributor

@dvesh3 dvesh3 commented Aug 21, 2023 •
edited by ghost

Changes in this pull request

Related to #15787

Additional info

WHAT

🤖 Generated by Copilot at 6ed64f9

Fix SQL errors in migration down functions by reordering or removing IF EXISTS clauses. This resolves issue #10976.

🤖 Generated by Copilot at 6ed64f9

down function changed
drop foreign keys before indexes
MySQL bugfix done

HOW

🤖 Generated by Copilot at 6ed64f9

  • Fix issue Pimcore X on MS Windows #10976 by dropping foreign keys before indexes in migration classes (link, link, link)
  • Remove unsupported IF EXISTS clause from SQL statements to drop foreign keys in migration classes Version20220120121803.php and Version20220120162621.php (link, link)

@dvesh3 dvesh3 added the Bug label Aug 21, 2023
@github-actions
Copy link

Review Checklist

  • Target branch (11.0 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dvesh3 dvesh3 merged commit dd81ef4 into 10.6 Aug 21, 2023
15 checks passed
@dvesh3 dvesh3 deleted the fix_down_migrations_mysql8 branch August 21, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dvesh3