[WebDAV] Fix assets are not accessible on webdav links #15856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Checklist
|
dvesh3
added a commit
to pimcore/demo
that referenced
this pull request
Aug 30, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
dvesh3
added a commit
to pimcore/skeleton
that referenced
this pull request
Aug 30, 2023
kingjia90
pushed a commit
to pimcore/demo
that referenced
this pull request
Aug 30, 2023
|
Mhh, had a thought after merging, this line shouldn't be appearing as bug fix upgrade note for In other words, we should consider this an overlooked mandatory change (and documentation note) that was due during upgrade to 11, and we are not fixing anything in 11.0.8 beside trying to fix the docs "retroactively" |
|
@kingjia90 yes, valid point that we should add this to 11.0.0 upgrade notes and i'll keep the notice in 11.0.8 section as well for the implementations already on v11. Could you please provide a followup? |
kingjia90
pushed a commit
to pimcore/skeleton
that referenced
this pull request
Aug 30, 2023
* Fix assets are not accessible on webdav links - related to pimcore/pimcore#15856 * review changes
|
followup done in #15859 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #15855
Additional info
WHAT
🤖 Generated by Copilot at 3ae379e
This pull request updates the nginx configuration documentation and the upgrade notes to fix the webDAV assets issue. It modifies the
locationrule for static files indoc/23_Installation_and_Upgrade/03_System_Setup_and_Hosting/02_Nginx_Configuration.mdand adds a note indoc/23_Installation_and_Upgrade/09_Upgrade_Notes/README.mdto explain the change.🤖 Generated by Copilot at 3ae379e
HOW
🤖 Generated by Copilot at 3ae379e