Fix uncaught error "Argument #1 ($id) must be of type int, null given" when userOwner of userModification is null

[atul-emico]

When userOwner and userModification are not set that time search by id is throwing error.

php.CRITICAL: Uncaught Error: Pimcore\Model\User\AbstractUser::getById(): Argument #1 ($id) must be of type int, null given, called in {project_root}/var/cache/acceptance/twig/ac/ac4a382cb38374880f7892b33abdbe63.php on line 174 {"exception":"[object] (TypeError(code: 0): Pimcore\Model\User\AbstractUser::getById(): Argument #1 ($id) must be of type int, null given, called in {project_root}/var/cache/acceptance/twig/ac/ac4a382cb38374880f7892b33abdbe63.php on line 174 at {project_root}/vendor/pimcore/pimcore/models/User/AbstractUser.php:41)"} []

File - templates/searchadmin/search/quicksearch/info_table.html.twig
Line number - 52 - 66

{% set owner = pimcore_user(element.getUserOwner()) %}
{% if owner is instanceof('\Pimcore\Model\User') %}

{{ 'owner'|trans([],'admin') }}
{{ owner.name }}

{% endif %}

  {% set editor = pimcore_user(element.getUserModification()) %}
  {% if editor is instanceof('\\Pimcore\\Model\\User') %}
      <tr>
          <th>{{ 'usermodification'|trans([],'admin') }}</th>
          <td>{{ editor.name }}</td>
      </tr>
  {% endif %}

There is no condition set.

[CLAassistant]

All committers have signed the CLA.

[github-actions]

Review Checklist

• Target branch (11.0 for bug fixes, others 11.x)
• Tests (if it's testable code, there should be a test for it - get help)
• Docs (every functionality needs to be documented, see here)
• Migration incl. install.sql (e.g. if the database schema changes, ...)
• Upgrade notes (deprecations, important information, migration hints, ...)
• Label
• Milestone

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[blankse]

I think, we should change the template:

{% set userModificationId = element.getUserModification() %}
{% set editor = userModificationId ? pimcore_user(userModificationId) : null %}

[blankse]

@atul-emico I created a alternative PR pimcore/admin-ui-classic-bundle#262

[kingjia90]

Closing in favor of pimcore/admin-ui-classic-bundle#262

Thank you again for reporting and the PRs!

[atul-emico]

@blankse

Thanks for the quick fix. That will be good approach.