Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web2Print] Utilize flysystem to support containerized infrastructure for print pages #16062

Closed
wants to merge 1 commit into from

Conversation

jremmurd
Copy link
Contributor

@jremmurd jremmurd commented Oct 6, 2023

With this PR printpages store their config in the configured temp storage and not in the filesystem of the current process.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Review Checklist

  • Target branch (11.0 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug D 2 Bugs
Vulnerability E 5 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 438 Code Smells

No Coverage information No Coverage information
6.0% 6.0% Duplication

@dvesh3
Copy link
Contributor

dvesh3 commented Oct 9, 2023

@jremmurd please check tests are failing. thanks!

@jremmurd
Copy link
Contributor Author

jremmurd commented Oct 9, 2023

@jremmurd please check tests are failing. thanks!

Hi @dvesh3, I cant see how the failing tests are related to this PR

Error: Parameter #1 $field (string) of method Pimcore\Helper\CsvFormulaFormatter::unEscapeField() is not contravariant with parameter #1 $cell (mixed) of method League\Csv\EscapeFormula::unescapeField().

In the "files changed" tab, Its listed under "Unchanged files with check annotations"

@dvesh3
Copy link
Contributor

dvesh3 commented Oct 10, 2023

@jremmurd 10.6 reached EOL. please rebase the PR on 11.0 branch. thanks!

@brusch
Copy link
Member

brusch commented Oct 10, 2023

@jremmurd @dvesh3 please re-create the PR here: https://github.com/pimcore/web-to-print-bundle as we moved web-to-print to it's own bundle 😊 Thanks!

@brusch brusch closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants