issue 16039: update versionCount also if versions are disabled #16120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Checklist
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi @chm0815 Pimcore 10.6 reached EOL so we don't accept contributions for this version anymore. Please rebase it on branch 11.1 only if it is reproducible on latest version v11.1.0 otherwise please close this PR. thanks for your understanding 😊 |
|
Rebased the PR to pimcore 11.1 |
|
the failing test is not related to the changes here. |
|
@chm0815 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #issue 16039
HOW
The versionCount will now also be set when version creation is disabled for the the current process.