Solution for dealing with a LazyCommand - Bug #16160

[MarkTro]

Resolves the problem that the comand can be a LazyCommand instead of the real DoctrineCommand.

[github-actions]

Review Checklist

• Target branch (11.0 for bug fixes, others 11.x)
• Tests (if it's testable code, there should be a test for it - get help)
• Docs (every functionality needs to be documented, see here)
• Migration incl. install.sql (e.g. if the database schema changes, ...)
• Upgrade notes (deprecations, important information, migration hints, ...)
• Label
• Milestone

[MarkTro]

It's a little bit confusing in the description of creating a merge request the base branch for bug fixes is "10.5", which is an older version, and in your checklist above is "11.0".

[kingjia90]

It's a little bit confusing in the description of creating a merge request the base branch for bug fixes is "10.5", which is an older version, and in your checklist above is "11.0".

The checklist is outdated, it should be 11.1, while 10.5 and 10.6 are not supported anymore, they are EOL.

[MarkTro]

Ok. So your announcements are more relevant than the mentioning in the system messages. :-)

[DuckThom]

Symfony appears to be doing this in the Application

        if ($command instanceof LazyCommand) {
            $command = $command->getCommand();
        }

Wouldn't is be a cleaner solution to use something like this as well? For example:

    public function add(Command $command): ?Command
    {
        if ($command instanceof LazyCommand) {
            $command = $command->getCommand();
        }

        if ($command instanceof DoctrineCommand) {
            $definition = $command->getDefinition();

I just ran into this error aswell (both on Pimcore 11.0 and 11.1) and adding the instanceof LazyCommand check appears to have solved it for me.

[MarkTro]

@DuckThom : That is also a nice solution. The difference is that every LazyCommand which passes will be loaded. I don't know if this have a big impact or not. I guess not, because the Command might be load during the request anyway.

[kingjia90]

Tests are likely failing due the branch not being up-to-date

Could you please pull and merge 11.1 into it?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[MarkTro]

@kingjia90

Could you please pull and merge 11.1 into it?

Done.

[jdreesen]

@MarkTro you merged 11.x instead of 11.1, so it now contains many unrelated commits.

[kingjia90]

BTW I've already opened a PR #16257 in replace of this branch

[dvesh3]

Closed in favor of #16257. thank you!