Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pimcore 10.6 path in editable for relation #16247

Closed
wants to merge 2 commits into from

Conversation

Gerhard-Kanzler
Copy link
Contributor

@Gerhard-Kanzler Gerhard-Kanzler commented Nov 13, 2023

in editmode the editable relation path should be the internal path (like domain.com/domain/snippet) and not the full path (like: domain2.com/snippet).
This cause an error in snippet or it looks blank.

Fix issue #16192 for Pimcore 10.6

Changes in this pull request

Resolves #

Additional info

WHAT

馃 Generated by Copilot at 2806035

Fix snippet path resolution in edit mode. Use getPath and getKey instead of getFullPath in models/Document/Editable/Snippet.php.

馃 Generated by Copilot at 2806035

getDataEditmode
Fixes snippet path bug now
Autumn leaves falling

HOW

馃 Generated by Copilot at 2806035

  • Fix bug in resolving snippet path for edit mode (link)

Copy link

Review Checklist

  • Target branch (11.0 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@Gerhard-Kanzler Gerhard-Kanzler changed the title fix: path in editable for relation fix: Pimcore 10.6 path in editable for relation Nov 13, 2023
Copy link

sonarcloud bot commented Nov 13, 2023

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@robertSt7 robertSt7 added the Bug label Nov 15, 2023
@dvesh3
Copy link
Contributor

dvesh3 commented Nov 23, 2023

Sorry, not accepting changes anymore for 10.6 as Pimcore 10.6 reached EOL. thanks!

@dvesh3 dvesh3 closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants