Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when $include is null when rendering #16314

Merged
merged 1 commit into from Dec 6, 2023
Merged

Fix error when $include is null when rendering #16314

merged 1 commit into from Dec 6, 2023

Conversation

fashxp
Copy link
Member

@fashxp fashxp commented Nov 29, 2023

when calling IncludeRenderer::render with $include == null (which is theoretically possible), an error is thrown...

This PR fixes that.

@fashxp fashxp added the Bug label Nov 29, 2023
@fashxp fashxp added this to the 11.1.3 milestone Nov 29, 2023
@github-actions GitHub Actions
Copy link

Review Checklist

  • Target branch (11.1 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@blankse
Copy link
Contributor

blankse commented Dec 1, 2023

Target branch should be 11.1 for bug fixes.

@fashxp fashxp changed the base branch from 11.x to 11.1 December 4, 2023 09:47
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fashxp fashxp merged commit d4b56a4 into 11.1 Dec 6, 2023
22 of 27 checks passed
@kingjia90 kingjia90 deleted the fix-null-rendering branch December 19, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
11.1.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fashxp @blankse