Data objects: saving relations, exclude non-relational fields from condition #16598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Checklist
|
This comment was marked as resolved.
This comment was marked as resolved.
|
kingjia90
reviewed
Mar 27, 2024
| if (!$this->model->isLazyKeyLoaded($fieldName) || $fd instanceof DataObject\ClassDefinition\Data\ReverseObjectRelation) { | ||
| //this is a relation subject to lazy loading - it has not been loaded | ||
| $untouchable[] = $fieldName; | ||
| if($fd instanceof DataObject\ClassDefinition\Data\Relations\AbstractRelations) { |
There was a problem hiding this comment.
Could you please share some insights behind this change?
By following the $untouchable var usages, ended up in this case in URL Slug data type
pimcore/models/DataObject/ClassDefinition/Data/UrlSlug.php
Lines 176 to 178 in 8d64417
Before PR it's true, after PR is always false, not sure if there was something legacy leftover but looks like a potential behavior change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.