Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix o_ prefix on foreign keys by Migration #16657

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Fix o_ prefix on foreign keys by Migration #16657

merged 3 commits into from
Feb 23, 2024

Conversation

ibousfiha
Copy link
Contributor

@ibousfiha ibousfiha commented Feb 22, 2024 •
edited
Loading

Changes in this pull request

Resolves #16620
Linked to #16621

Additional info

@github-actions GitHub Actions
Copy link

Review Checklist

  • Target branch (11.1 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@dpfaffenbauer
Copy link
Contributor

I don't really think this belongs in the core, these are foreign keys from the demo

@ibousfiha ibousfiha self-assigned this Feb 23, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kingjia90 kingjia90 added this to the 11.1.6 milestone Feb 23, 2024
@kingjia90 kingjia90 added the Bug label Feb 23, 2024
@kingjia90 kingjia90 merged commit 3ecc455 into 11.1 Feb 23, 2024
14 checks passed
@kingjia90 kingjia90 deleted the migration_removing_o_prefix_on_FKs branch February 23, 2024 12:19
@ibousfiha ibousfiha mentioned this pull request Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingjia90 kingjia90 kingjia90 approved these changes

Assignees
No one assigned
Labels
Bug Pimcore:ToDo
Projects
None yet
Milestone
11.1.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ibousfiha @dpfaffenbauer @kingjia90 @wisconaut