Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data Objects] Password : Deprecate support for algorithms other than password_hash #16736

Merged
merged 4 commits into from
Mar 12, 2024
Merged

[Data Objects] Password : Deprecate support for algorithms other than password_hash #16736

merged 4 commits into from
Mar 12, 2024

Conversation

kingjia90
Copy link
Contributor

Changes in this pull request

Resolves #16294

Additional info

@kingjia90 kingjia90 added this to the 11.2.0 milestone Mar 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Review Checklist

  • Target branch (11.1 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@kingjia90 kingjia90 mentioned this pull request Mar 5, 2024
Merged
@brusch
Copy link
Member

brusch commented Mar 12, 2024

@kingjia90 I'd even deprecate get/setAlgorithm incl. the property as we don't need it anymore in future. Pushed it already to your branch.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kingjia90 kingjia90 merged commit 2e2caae into 11.x Mar 12, 2024
18 checks passed
@kingjia90 kingjia90 deleted the deprecate-hash-pass branch March 12, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brusch brusch brusch requested changes

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
11.2.0
Development

Successfully merging this pull request may close these issues.

[Data Objects] Password : Deprecate support for algorithms other than password_hash
2 participants
@kingjia90 @brusch