Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion for pimcore:bundle:(un)install #16932

Open
wants to merge 1 commit into
base: 11.x
Choose a base branch
from

Conversation

matthiashamacher
Copy link
Contributor

Changes in this pull request

Startet as idea to implement completion for the pimcore:bundle:(un)install commands ended with refactoring / updating all pimcore:bundle:* commands and related classes:

  • Added completion for bundle argument for pimcore:bundle:(un)install
  • Refactored pimcore:bundle:* to use AsCommand-Attribute
  • Remove unused functions:
    • AbstractBundleCommand::configureDescriptionAndHelp
    • AbstractBundleCommand::buildName -> no longer needed as names are set via AsCommand directly
  • Remove unnecessary if-else constructs in favor of early returns
  • Use Command::SUCCESS and Command::FAILURE instead of ints
  • Add readonly to properties
  • Remove $e from exceptions when unused
  • Use $this->io->table() instead of new Table() for simplification
  • Some more refactoring

Signed-off-by: Matthias Hamacher <m.hamacher@basecom.de>
Copy link

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

Copy link

sonarcloud bot commented Apr 13, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
17.1% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants