Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ecommerce][Tracking] add GTM tracker #5348

Merged
merged 2 commits into from Dec 3, 2019

Conversation

ljthiel
Copy link
Contributor

@ljthiel ljthiel commented Nov 27, 2019

Add support for tracking via gtm dataLayer

todos:

@fashxp
Copy link
Member

fashxp commented Nov 28, 2019

should we merge this first and then add necessary changes from #5347 in #5347?

@ljthiel ljthiel changed the title [WIP] [Ecommerce][Tracking] add GTM tracker [Ecommerce][Tracking] add GTM tracker Nov 29, 2019
@ljthiel
Copy link
Contributor Author

ljthiel commented Nov 29, 2019

should we merge this first and then add necessary changes from #5347 in #5347?

Seems like a good idea :)
Methods for the TrackingCodeAwareInterface should be implemented already.

@fashxp
Copy link
Member

fashxp commented Dec 2, 2019

is this now finished and ready to be reviewed? @ljthiel @markus-moser

@markus-moser
Copy link
Contributor

should be ready to be reviewed

@fashxp fashxp marked this pull request as ready for review December 3, 2019 09:35
@fashxp fashxp self-assigned this Dec 3, 2019
@fashxp
Copy link
Member

fashxp commented Dec 3, 2019

thx!

@fashxp fashxp merged commit 94a2193 into pimcore:master Dec 3, 2019
@blankse
Copy link
Contributor

blankse commented Dec 4, 2019

@ljthiel I get an error now, when the PimcoreEcommerceFrameworkBundle is not activated:
Cannot autowire service "Pimcore\Analytics\GoogleTagManager\EventSubscriber\TrackingCodeSubscriber": argument "$trackingManager" of method "__construct()" references class "Pimcore\Bundle\EcommerceFrameworkBundle\Tracking\TrackingManager" but no such service exists.

@fashxp
Copy link
Member

fashxp commented Dec 4, 2019

@blankse should be fixed now, can you please recheck?

@blankse
Copy link
Contributor

blankse commented Dec 4, 2019

@fashxp Yes it works now. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants