Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update $context['fieldname'] to $context['containerKey'] #5581

Merged
merged 1 commit into from Jan 14, 2020
Merged

Update $context['fieldname'] to $context['containerKey'] #5581

merged 1 commit into from Jan 14, 2020

Conversation

Gerhard-Kanzler
Copy link
Contributor

@Gerhard-Kanzler Gerhard-Kanzler commented Jan 14, 2020

Update a bug from previous changes for the Block element.
$context['fieldname'] to $context['containerKey']
Regression of #5471

@blankse
Copy link
Contributor

blankse commented Jan 14, 2020

I don't think its a regression from #5471
Rather from 2357caa

@brusch
Copy link
Member

brusch commented Jan 14, 2020

Thanks a lot! 🙏

@brusch brusch merged commit e8ea0c3 into pimcore:master Jan 14, 2020
@brusch brusch added the Bug label Jan 14, 2020
@brusch brusch self-assigned this Jan 14, 2020
@weisswurstkanone
Copy link
Contributor

@Gerhard-Kanzler , please described exactly how your use case differs from #4202

@brusch
Copy link
Member

brusch commented Jan 14, 2020

Sorry, that was to quick :)

weisswurstkanone pushed a commit that referenced this pull request Jan 15, 2020
If you had a localizedfield in the Block "containerType" in your Object, and would insert some Data, you get an error about the fieldDefinition.
So after change to "containerType" they can find the correct fieldDefinition
See: #5581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants