[AdminBundle] Mark classes internal/final

[dvesh3]

Changes in this pull request

Resolves partially #7189

Additional info

[roland4432]

What's the reason for all classes to be marked as final?

[brusch]

@roland4432 Because they are not intended to be overridden or customized. The BC promise / SemVer doesn't apply to those classes.

[roland4432]

Could you maybe leave that decission to the programmer?
This breaks dozens of projects and doesn't make any sense in the symfony flow at all.

And.. it doesn't even have the desired effect, since you can still override the controller just not extend it.

services:
       Pimcore\Bundle\AdminBundle\Controller\Admin\IndexController:
          class: AppBundle\Controller\Admin\IndexController

and the controller is replaced...

[roland4432]

I am interested in what top contributors like @BlackbitNeueMedien @dpfaffenbauer @jdreesen think about that...

[BlackbitDevs]

I never understood the argument to make classes final. Arguments like

Using the class for something else by overriding part of its behavior may jeopardize its integrity. The state of the extended object may become unpredictable or inconsistent with the state of the original object.
from https://matthiasnoback.nl/2018/09/final-classes-by-default-why/

are simply not true. If you want to protect internal state of properties, then it is fine for me to make them private. But to prohibit extending a class will only lead to a lot of copy-paste. There are a lot of use-cases where reusing / extending the AdminBundle controllers will on the one hand make custom features easier to implement and on the other hand make them easier to migrate. Because what will happen is that all the custom features which currently extend the AdminBundle controllers which @roland4432 mentions will have to copy the methods from the original classes to still work. Then this at first will work but when those AdminBundle classes get changed, the copied methods might again not work. Of course now you will say that developers have to check their code anyway for Pimcore updates - but what is the advantage of making those classes final?

[brusch]

For me it would be ok as well to just tag them as @internal, but that would still mean that we're not maintaining backward-compatibility for those classes - "use at your own risk".

[roland4432]

Would be totally fine with that.