[CoreBundle] Mark classes as final/internal #8458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nced in the docs)
brusch
approved these changes
Mar 19, 2021
roland4432
pushed a commit
to roland4432/pimcore
that referenced
this pull request
Apr 1, 2021
* [CoreBundle] Mark commands as internal - pimcore#7189 * [CoreBundle] Mark PublicServicesController final & internal pimcore#7189 * [CoreBundle] Event Listeners declared as final and marked internal - pimcore#7189 * [CoreBundle] Migrations declared as final and marked internal - pimcore#7189 * [AdminBundle] Rename FrontendRoutingListener to RoutingListener - pimcore#7189 * [CoreBundle] Mark classes as final/internal pimcore#7189 * FullPageCacheListener should be final, but not @internal (it's referenced in the docs) Co-authored-by: Bernhard Rusch <bernhard.rusch@elements.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves partially #7189
Additional info
FrontendRoutingListenerrenamed toRoutingListener, as it handles admin routes as well.