[Bug]: Add EditmodeDataInterface to Output Channel Table editable #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this editable and setting some data and save, it would not load again.
This is likely due a change of pimcore/pimcore#10607 and by not having that interface, it would use
getData()instead ofgetDataEditmode()See also https://github.com/pimcore/pimcore/blob/5f3de5110b90ea4acbd7e6ec86e7c48a9b67cb12/models/Document/Editable.php#L164-L168
ToDo: check if bundle 4.x with Pimcore 10.x is affected.10.x is fine, the removal of the bc layer happened in 11