Support for low/high gas variants #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 827858316
💛 - Coveralls |
Gadgetoid
force-pushed
the
patch-high-gas-support
branch
from
f148b08
to
d1856c5
Compare
The BME688 is a "high" gas resistance variant of the BME680 and requires a slightly different init and gas compensation formula. This change attempts to auto-detect the chip variant ID and do the right thing. The constant ENABLE_GAS_MEAS is now set to -1 for back-compat, and passing this into set_gas_status will use the detected variant.
Gadgetoid
force-pushed
the
patch-high-gas-support
branch
from
d1856c5
to
b79558c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BME688 is a "high" gas resistance variant of the BME680 and requires a slightly different init and gas compensation formula.
This change attempts to auto-detect the chip variant ID and do the right thing.
The constant ENABLE_GAS_MEAS is now set to -1 for back-compat, and passing this into set_gas_status will use the detected variant.