Fix reassignment of variable in pressure calculation algo #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I'll run a test tomorrow. |
|
@gkluoe you are my favourite person right now. You'll never believe it, but I was looking into this yesterday and was having a hard enough time finding a BME680 that even works. Apparently we've sold or hoarded them all somewhere. @jorisvervuurt if you confirm this works, and the Python 2/3 issues are squashed then I'll push out a new release ASAP. |
|
Before installing the fixed version, pressure was measured to be ~1018 hPa while it should measure ~1006 hPa. After installing the fixed version, it measures ~1004 hPa and it now also works in Python 3. I think it's safe to say that @gkluoe has fixed the problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found it! I'm not 100% sure what's going on here, but I think the problem is that you reassigned var1 but the last part of the calculation relied on its original value.
With this patch I get matching values from the C and the Python.