Support disabling LED/button for #70 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs rebasing to incorporate the change to APA102, which allows pin setup to be skipped- previously legacy Plasma was setting up the LED pins on import but APA102 does not initialise them until instantiation. |
This changeset adds disable_button and disable_led arguments to FanShim so that the GPIO setup for these features can be avoided. This is mostly for issues with HyperPixel raised in #70 but any should be useful for other instances where Fan SHIM might conflict pins with another board.
Gadgetoid
force-pushed
the
support-disable-led-button
branch
from
618985b
to
4f9fad1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds disable_button and disable_led arguments to FanShim so that the GPIO setup for these features can be avoided.
This is mostly for issues with HyperPixel raised in #70 but any should be useful for other instances where Fan SHIM might conflict pins with another board.
This will break - #49
Specifically - 058ebc3
But this is intentional, since
noledis intended to avoid the LED being set up or written, for compatibility with add-on boards that require the pins. Additionally, writing the LED state once will not guarantee it actually stays that way, since the "smart" LEDs can often interpret random noise as signal and decide to turn themselves another colour.