Fix EPDType.encode str vs bytes conflict #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: EPDType.encode tried to pack a str into a 22p struct format. However, in Python 3 onward, 22p will only accept a bytes. Resolution: Encode the string using the ASCII charset. This guarantees that only one byte is used per character. Non-ASCII characters will never be generated.
|
Ah the string/bytes nonsense of Python 2.x / 3.x continues to catch me out! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: EPDType.encode tried to pack a str into a 22p struct format. However, in
Python 3 onward, 22p will only accept a bytes.
Resolution: Encode the string using the ASCII charset. This guarantees that
only one byte is used per character. Non-ASCII characters will never be
generated.