MicroPython: Revert to vanilla module, build without MPY hacks. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gadgetoid
force-pushed
the
revert-builtin
branch
2 times, most recently
from
6a82fef
to
5b95084
Compare
Gadgetoid
force-pushed
the
revert-builtin
branch
from
5b95084
to
75ffe4a
Compare
Gadgetoid
force-pushed
the
revert-builtin
branch
from
75ffe4a
to
029906f
Compare
|
I have introduced a new hack into It works. But it's slower. I think? My isolated tests suggest this should have been faster, and some clarification about how function lookups happen seem to confirm this. But Ninja Thief runs perceptibly slower. The question, perhaps, since this relies on fewer hacks to upstream MicroPython and is building against a bleeding-edge version (should easily bump to 1.20 when release happens) then is it slow enough to warrant leaving it to rot in PR purgatory, or should we take the hit and move on? |
Gadgetoid
force-pushed
the
revert-builtin
branch
8 times, most recently
from
fad7412
to
3f90b88
Compare
Borrows the build setup from Badger OS which- * Uses a uf2-manifest and dir2uf2 to append examples in a user-visible filesystem * Uses MICROPY_BOARD_DIR to specify an out-of-tree board def * Uses ccache and caches MicroPython (compiled tools) * Builds against upstream MicroPython
Gadgetoid
force-pushed
the
revert-builtin
branch
8 times, most recently
from
4c93c86
to
f03ce0e
Compare
* Use string_view in lieu of string * Rewrite _parse_escape_code to be compatible with string_view * Allocate a static buffer_t _SCREEN if DYNAMIC_BUFFER not set
Gadgetoid
force-pushed
the
revert-builtin
branch
2 times, most recently
from
dfb6486
to
d5a56db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running some tests my figures seemed to suggest that not only is using builtins unnecessary for PicoSystem but somehow results in it being slower.
This change reverts back to a plain MicroPython C++ module and is intended to build against a mostly vanilla upstream MicroPython.
Mostly.
It still needs: