Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Environment has been added #932

Closed
wants to merge 9 commits into from
Closed

Docker Environment has been added #932

wants to merge 9 commits into from

Conversation

Bleala
Copy link
Contributor

@Bleala Bleala commented Aug 21, 2021

Hello there!

I created a full functional and minimalistic Docker container containing Vdirsyncer.

bleala/vdirsyncer

It's based on alpine linux and people are able to use the sync time they want with the Ofelia implementation.

Feel free to test and if it's okay for the maintainers of this great projekt, it would be an honor if you submit my pull request, to add it to this repository :).

Greetings

@Bleala
Copy link
Contributor Author

Bleala commented Aug 22, 2021

Update:
I've done an almost complete rewrite of the container.

Now it is way more userfriendly.
I dropped Ofelia and implemented Cron and Users can adjust the synctime with an environment variable (CRON_TIME).

There are also environment variables for AUTODISCOVER and AUTOSYNC, which enable automatic discover and automatic sync from Vdirsyncer.

To sum up, more userfriendly, just one container and more functions, feel free to test :) Bleala/Vdirsyncer

@WhyNotHugo
Copy link
Member

Hi. Thanks for the contribution.

I'd much rather include the itself Dockerfile in-repository. I'm not sure where the Dockerfile for this image is right now.

@Bleala
Copy link
Contributor Author

Bleala commented Aug 23, 2021

@WhyNotHugo
It's not the best way to include only the Dockerfile because i also added some scripts, example files, etc.

You can find the Github Repo here:
https://github.com/Bleala/Vdirsyncer-DOCKERIZED

Docker Hub:
https://hub.docker.com/r/bleala/vdirsyncer

Maybe the best way is to shout out there is a valid docker container (in the Readme or Docs) and link to the repository. I'll keep it updated, build the containers and push them to Docker Hub.

What you thinking?

@WhyNotHugo
Copy link
Member

WhyNotHugo commented Sep 2, 2021

Your Dockerfiles looks pretty good, just changing it to have ENTRYPOINT ["/usr/bin/vdirsyncer"] would be sufficient change to merge it (well, also without the ENV and HEALTCHECK, since it wouldn't apply).

Alpine sounds like a small, solid base to run this. Have you considered using python3.9-alpine as a base image? Does it make any difference in terms of build speed / image size?

@WhyNotHugo
Copy link
Member

Oh, your introduction to vdirsyncer would also be a welcome improvement to ours in the docs.

@Bleala
Copy link
Contributor Author

Bleala commented Sep 7, 2021

@WhyNotHugo
I considered running the container with ENTRYPOINT ["/usr/bin/vdirsyncer"], but as i am a big fan of customization, and i like it if people give you the opportunity to change some things in containers, i decided to add environment variables.
The most useful part here is that people can edit the synctime as they want to, so i don't want to change the Dockerfile this way. But it's not a problem, you don't have to merge my Dockerile and that stuff, i just wanted that people can see, that there is a valid docker container with vdirsyncer.

Yeah i tried the python (alpine) base image too, there was not much difference in build time and size, but somehow the container with alpine as base image was a little bit smaller, so i stayed with the normal alpine image instead of the python one.

What introduction to you exactly mean? My README or the manual i wrote in the issue in my github repo?
I would like to help you improve your docs, because i like vdirsyncer very much. :)
Could you give me a hint on how to open a pull request for the docs? Never did that before^^

@Wastus
Copy link

Wastus commented Jan 9, 2022

Thanks Bleala, I tried your Docker image yesterday and got my sync to work from my current server to a VM I'm testing a new server setup on. Your documentation was really helpful and gave some good hints on what to look out for.

@Bleala
Copy link
Contributor Author

Bleala commented Jan 9, 2022

Thanks Bleala, I tried your Docker image yesterday and got my sync to work from my current server to a VM I'm testing a new server setup on. Your documentation was really helpful and gave some good hints on what to look out for.

You're welcome! :)
Good to hear, that everything worked fine for you and my documentation helped you.

@@ -59,6 +59,13 @@ Links of interest

* `Donations <https://vdirsyncer.pimutils.org/en/stable/donations.html>`_

Dockerized
=================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note here mentioning that this is not official? Mostly, I want it to be clear that this is not something maintained upstream. I'm okay with merging this otherwise.

Sorry for the huge delay, I looked into this a bunch of times but always had doubts on how it worked. I see that now you're using cron and a much simpler/unix-like approach to things, which I can actually understand how it works easily.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
yes that's not a problem, i'll add a note, that this container is not official.

Should i create a new PR with the changes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a new PR with a note, that the Docker container is not an official one
PR #1119

added a note, that the docker build is unofficial
fix: changelog
fix: link to github repository
fix: change Docker Hub to GitHub
@Bleala Bleala closed this by deleting the head repository Feb 16, 2024
@Bleala Bleala mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants