Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker Environment has been added #932

Closed
wants to merge 9 commits into from
Closed

Docker Environment has been added #932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2466d65
Docker Environment has been added
Bleala Aug 21, 2021
100d74f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 21, 2021
ece217e
Merge branch 'pimutils:main' into master
Bleala May 12, 2023
2a1a6e8
Merge pull request #1 from pimutils/main
Bleala Feb 16, 2024
ec45839
Update README.rst
Bleala Feb 16, 2024
b6c8da0
Update CHANGELOG.rst
Bleala Feb 16, 2024
c795c6c
Update README.rst
Bleala Feb 16, 2024
a5731c5
Update README.rst
Bleala Feb 16, 2024
66884b3
Update README.rst
Bleala Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Contributors
In alphabetical order:

- Ben Boeckel
- Bleala
- Christian Geier
- Clément Mondon
- Corey Hinshaw
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Version 0.19.3
- Fix crash when running ``vdirsyncer repair`` on a collection. :gh:`1019`
- Add an option to request vCard v4.0. :gh:`1066`
- Require matching ``BEGIN`` and ``END`` lines in vobjects. :gh:`1103`
- A Docker environment for Vdirsyncer has been added `Vdirsyncer DOCKERIZED <https://github.com/Bleala/Vdirsyncer-DOCKERIZED>`_.

Version 0.19.2
==============
Expand Down
9 changes: 9 additions & 0 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,15 @@ Links of interest

* `Donations <https://vdirsyncer.pimutils.org/en/stable/donations.html>`_

Dockerized
=================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note here mentioning that this is not official? Mostly, I want it to be clear that this is not something maintained upstream. I'm okay with merging this otherwise.

Sorry for the huge delay, I looked into this a bunch of times but always had doubts on how it worked. I see that now you're using cron and a much simpler/unix-like approach to things, which I can actually understand how it works easily.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
yes that's not a problem, i'll add a note, that this container is not official.

Should i create a new PR with the changes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a new PR with a note, that the Docker container is not an official one
PR #1119

If you want to run `Vdirsyncer <https://vdirsyncer.pimutils.org/en/stable/>`_ in a
Docker environment, you can check out the following GitHub Repository:

* `Vdirsyncer DOCKERIZED <https://github.com/Bleala/Vdirsyncer-DOCKERIZED>`_

Note: This is an unofficial Docker build, this is maintained by `Bleala <https://github.com/Bleala>`_.

License
=======

Expand Down