Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 3.3.0 for release #371

Closed
wants to merge 4 commits into from
Closed

Bump version to 3.3.0 for release #371

wants to merge 4 commits into from

Conversation

blag
Copy link
Collaborator

@blag blag commented Sep 6, 2023

Changes proposed in this PR:

  • Bump version to 3.3.0 for release

Tips for an ideal PR

@blag
Copy link
Collaborator Author

blag commented Sep 7, 2023

No matter what configuration I tried, setuptools kept building a distribution with both account and tests packages in it. We shouldn't be including our tests package in our distribution.

So I tweaked the config to use Poetry to handle dependencies (poetry add/poetry remove/poetry lock), build the distribution (poetry build) and we can also use it to publish the distribution to PyPI (poetry publish).

Switching to a different package build system is a big change, so I'm happy to have a discussion about it.

@uhurusurfa
Copy link
Collaborator

I have no specific reasons to prefer setuptools over poetry but all the Pinax apps are all currently using setuptools and not sure if the Pinax rteam want to switch tools.
We probably will not get any communication with them as they seem to have abandoned the projects for the most part.
If you feel there is significant benefit to using Poetry I am up for it.

Did you look at this articlke to try to fix setuptools:
https://stackoverflow.com/questions/608855/excluding-a-top-level-directory-from-a-setuptools-package

@blag
Copy link
Collaborator Author

blag commented Sep 7, 2023

I figured out that setuptools wasn't my problem - it was MANIFEST.in. I'll close this and open a separate PR that readies this for version 3.3.0. It's much simpler.

I'd mildly prefer that we stick with what other Pinax projects use, but if we run into things we can't update (like their GHAs), I figure we can work around them and do what we want. However, now that I got things working with setuptools I think we stick with it for as long as it works for us.

@blag blag closed this Sep 7, 2023
@blag blag deleted the version-3.3 branch September 8, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants