Update Python and Django Support #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently not including Django 3 because one of the dependencies of this project, `pinax-images` currently doesn't support Django 3.
* Remove explicit inheritance from the builtin, object * Drop args from super calls
Python 3 strings are unicode by default
This was referenced Apr 6, 2020
Closed
|
Problem with pytz... |
|
Thanks for making this PR. I've read through it and approve (for what it's worth). |
jonathan-s
approved these changes
May 20, 2020
|
@jonathan-s Thank you for approving! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops EOLed Python and Django versions from Pinax Blog.
IMPORTANT
Django 3 is not yet added to the support matrix for this app because a dependency, Pinax Images, does not currently support Django 3.
Thankfully, there's a PR to fix that at pinax/pinax-images#28
When that is fixed, and a Django 3 supporting version of the dependency is available on PyPI, Django 3 support can be added to this app.
When all of this is done, issue #128 will be fixed.