-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Django 2.2 via django-jsonfield-backport #34
Labels
Comments
Sounds great!
… On Aug 15, 2020, at 1:38 PM, Jacob Wegner ***@***.***> wrote:
As discussed in #32, #33 drops Django 2.2 support.
Since Django 2.2 is an LTS release, the co-author of the new JSONField added in 3.1 actually created a backport package:
https://github.com/laymonage/django-jsonfield-backport#why-create-another-one
Django's release process does not backport new features to previous feature releases. However, the current LTS release is 2.2 which is still supported until April 2022. The next LTS release is Django 3.2 in April 2021 that happens to be the end of extended support for Django 3.1.
Some projects only use LTS releases of Django. There are also incompatibilities between Django 3.0 and 3.1. Therefore, using Django 3.1 may not be an option for some people at the moment
Since JSONField seems to be in popular demand and that it works well as a standalone package, I decided to create a backport.
I'd like to propose we introduce a small shim to the 5.x release that:
adds django-jsonfield-backport as an optional dependency
modifies models.py and the initial migration to work with the shim'd field
provides documentation to site developers on how to use eventlog in Django~2.2 projects via django-jsonfield-backport
As part of this work, we would update the tox test matrix to prove out this support.
@paltman and @KatherineMichel: Does this seem reasonable to you? This would allow us to leverage the awesome JSONField while still keeping Django 2.2 compatibility as outlined in https://github.com/pinax/pinax/wiki/Pinax-20.XX-Release-Plan#pinax-20xx-release-overview.
If so, I can prepare a PR within the next week or so.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@jacobwegner Awesome, thank you! |
This was referenced Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed in #32, #33 drops Django 2.2 support.
Since Django 2.2 is an LTS release, the co-author of the new JSONField added in 3.1 actually created a backport package:
https://github.com/laymonage/django-jsonfield-backport#why-create-another-one
I'd like to propose we introduce a small shim to the 5.x release that:
models.py
and the initial migration to work with the shim'd fieldeventlog
in Django~2.2 projects via django-jsonfield-backportAs part of this work, we would update the
tox
test matrix to prove out this support.@paltman and @KatherineMichel: Does this seem reasonable to you? This would allow us to leverage the awesome JSONField while still keeping Django 2.2 compatibility as outlined in https://github.com/pinax/pinax/wiki/Pinax-20.XX-Release-Plan#pinax-20xx-release-overview.
If so, I can prepare a PR within the next week or so.
Thanks!
The text was updated successfully, but these errors were encountered: