Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Django 3.1 models.JSONField #33

Merged
merged 2 commits into from
Aug 15, 2020
Merged

Use Django 3.1 models.JSONField #33

merged 2 commits into from
Aug 15, 2020

Conversation

paltman
Copy link
Member

@paltman paltman commented Aug 15, 2020

This drops all prior Django support and will take us to v5 for this library. As such, migrations have been reset to a single initial migration which should be fine if upgrading prior versions as there has been no schema change but should alleviate having to have postgres installed just to run migrations.

This drops all prior Django support and will take us to v5 for this library.  As such, migrations have been reset to a single initial migration which should be fine if upgrading prior versions as there has been no schema change but should alleviate having to have postgres installed just to run migrations.
From #22

Copying in rather than dealing with merge because of the JSONField and migrations changes
@codecov
Copy link

codecov bot commented Aug 15, 2020

Codecov Report

Merging #33 into master will increase coverage by 12.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #33       +/-   ##
===========================================
+ Coverage   80.20%   92.75%   +12.54%     
===========================================
  Files           6        5        -1     
  Lines          96       69       -27     
  Branches       10        5        -5     
===========================================
- Hits           77       64       -13     
+ Misses         14        4       -10     
+ Partials        5        1        -4     
Flag Coverage Δ
#py36dj22 ?
#py36dj30 ?
#py36dj31 92.30% <100.00%> (?)
#py37dj22 ?
#py37dj30 ?
#py37dj31 92.30% <100.00%> (?)
#py38dj22 ?
#py38dj30 ?
#py38dj31 92.75% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pinax/eventlog/models.py 100.00% <100.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a93d7...730c4b7. Read the comment docs.

@paltman paltman merged commit a7e102e into master Aug 15, 2020
@paltman paltman deleted the json-field branch August 15, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant