Updated models.py to support MYSQL JSON Field #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need eventlog to work with MySQL.
|
@patrickscottbest Awesome, thank you! |
|
This PR changed |
|
@patrickscottbest Is this something you might be able to submit a PR to fix? |
|
Hi yes I will take a look, but if memory serves we’ve got a fundamental problem with the existing migrations, I think I had to wipe some of them ... researching
… On Jul 27, 2020, at 3:42 PM, KatherineMichel ***@***.***> wrote:
@patrickscottbest Is this something you might be able to submit a PR to fix?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I've commented on this in the bug, we seem to have a code divergence problem since migration See #32 In other words, pinax-eventlog may be locked into postgresql with the inclusion of this file in the overall package. Take it out, and now you've bonked the installed userbase with bad migrations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need eventlog to work with MySQL.