Like list tag defaults to all registerd models #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{% likes user as like_list %} defaults to using all registered models
when no models are specified, to allow easy listing of all likes in an
application - which is probably the main use case for this.
| @@ -5,6 +5,7 @@ from django.core.urlresolvers import reverse | |||
| from django.contrib.contenttypes.models import ContentType | |||
|
|
|||
| from phileo.models import Like | |||
| from phileo.utils import _allowed, LIKABLE_MODELS | |||
There was a problem hiding this comment.
I don't see _allowed used, should I remove this import or were you intending on using it and forgot to?
`phileo.utils_allowed` handles string arguments, and Model arguments now,
and treats them appropriately. This way, you can pass in either a Model
instance OR a string already in the 'app_name.model' format and both are
handled correctly.
When using the {% likes %} tag, the PHILEO_LIKABLE_MODELS list is
checked before the likes for that model are queried. If the model is not
in PHILEO_LIKABLE_MODELS, that model is skipped.
|
|
paltman
added a commit
that referenced
this pull request
Nov 29, 2011
Like list tag defaults to all registerd models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{% likes user as like_list %} defaults to using all likable models specified in PHILEO_LIKABLE_MODELS when no models are specified, to allow easy listing of all likes in an application - which is probably the main use case for this.