Improve actions.customers.create with existing Customer #364
Conversation
| "stripe_id": stripe_customer["id"] | ||
| } | ||
| ) | ||
| cus, created = models.Customer.objects.get_or_create(user=user) |
There was a problem hiding this comment.
StripeObject.stripe_id can't be null at present, so would this not fail if it came to creating?
There was a problem hiding this comment.
It is a CharField, and can be blank (validation for the default blank=False is skipped here).
But there can only be one blank stripe_id (it is a unique) field.
|
My main concern with this approach is the ordering of storage. The standard approach in this project seems to be to only ever create local database entries based on data that is confirmed to exist on Stripe's side. Reversing this means there is potential for orphaned, unpopulated Customer entries that do not correspond with any data in Stripe. Of course, the current ordering of Stripe then local DB results in the opposite problem where we may have orphaned data in Stripe that does not exist locally in our database. Not really sure if one is better than the other, but it makes sense to me to take a consistent approach, which would be Stripe data first, local DB storage second. @paltman what are your thoughts? |
|
Yes, I would like to keep focused on Stripe being the point of truth and local DB being a glorified cache of what Stripe has. Ideally, we should always be able to rebuild our local database (at least the pinax-stripe portion) by syncing data from the API. Though I know practically speaking at some point that becomes a very time-consuming task and there should be workarounds developed. |
|
Closing for now then. |
Ref: #341 (comment)