Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding multiline callable argument alignment preference. #112

Merged
merged 1 commit into from
Feb 20, 2016

Conversation

grahamu
Copy link
Contributor

@grahamu grahamu commented Feb 20, 2016

As per @brosner commenting on this code snippet:

    relationship_url = reverse("product-category-relationship-detail",
                               kwargs=dict(pk=product.pk))

I really don't like lining up arguments to the function call line like this. I personally just find it ugly. I don't know if we state anywhere this particular preference, but the typical style we use at Eldarion is:

relationship_url = reverse(
   "product-category-relationship-detail",
   kwargs=dict(pk=product.pk)
)

@paltman
Copy link
Member

paltman commented Feb 20, 2016

YES!

paltman added a commit that referenced this pull request Feb 20, 2016
Adding multiline callable argument alignment preference.
@paltman paltman merged commit 10bddc5 into pinax:master Feb 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants